-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mima command to run more quickly #415
Conversation
I'm actually not sure I want this enabled on JS and Native. MiMa is adding 4 minutes of computation on each matrix cell, and although I think it's important to have it enabled to help people who do not instinctively spot bincompat problems, I'm okay with the idea that running it on JVM only is probably good enough at this point in the life of the library, in particular when some contributors run a LOT of commits on each PR ... I know Scala isn't the most "green" language, far from it, but I'd rather we tried to keep computation usage low-ish, relatively speaking |
4 minutes is kind of outrageous. From a brief glance at your logs I wonder if it's a misconfiguration: for example the MiMa check for 2.13+js seems to be compiling your entire project. |
@armanbilge, you're right. @lewisjkl, in case you're not aware, we create cell-specific command here which let us invoke specific things for the particular combo run by CI. I'd expect a MiMa command to appear in this list, and for the GHA setup to have |
Looks like I need to tweak it a bit still, but I've got to head out for the day. I'll wrap it up on Monday. |
I disabled mima checks as per the convo above, happy to change that back if we want. I also updated so it uses a command from the desiredCommands list. |
Adds a matrix-specific command to allow mima to run more specifically