Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug in the instance id list copy #60

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Fixes a bug in the instance id list copy #60

merged 1 commit into from
Oct 27, 2021

Conversation

ncatelli
Copy link

@ncatelli ncatelli commented Oct 27, 2021 •
edited
Loading

General

This PR fixes a bug reported directly by @ledor473 that caused sessions to fail to look up instances by id using the -i flag. This was caused by a bad use of copy causing 0 instances to be copied from the array of user passed instance ids to an empty thread local slice.

./bin/ssm session -i <redacted> --profile <redacted> --region us-east-1
INFO    Retrieved 1 usable instances.

sh-4.2$

@ncatelli ncatelli merged commit 5eb1d6e into disneystreaming:develop Oct 27, 2021
@ncatelli ncatelli deleted the bugfix/session-i-flag-failing-to-resolve branch October 27, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ncatelli