More tests #53

carolinedil · 2018-06-27T17:30:13Z

I've added a number of tests:

Added Helpers Test for create_or_overwrite_file.
Added Crypto Test for encrypt_file which gives the wrong key into encrypt and expects the Wrong Key error. (need to add one for decrypt)
Added Crypto Test for decrypt_file that checks if error is properly conveyed when trying to decrypt a file that has "already been decrypted" (Simply have a file that is not in encrypted form).
Added Crypto Test for encrypt_file that checks if error is properly conveyed when trying to encrypt a file that has "already been encrypted".
Added Crypto Test for read_file that checks if it works on files with content written to them (I choose a string: "something")
Added Crypto test for read_file that checks if it throws an error when used on an empty file.
Added Crypto test for _restore_from_backup that checks what is output when plaintext has been encrypted and the resultant cipher text is decrypted then plaintext is altered.
Added Crypto test for _restore_from_backup that checks if it works under conditions with no alteration to cipher text or plaintext before restoration.

…y error

…ng to decrypt a file that has "already been decrypted" (Simply have a file that is not in encrypted form).

…ng to encrypt a file that has already been encrypted.

…t written to them.

…g to use read_file on an empty file.

…n plaintext has been encrypted and the resultant cipher text is decrypted then plaintext is altered.

…ditions with no alteration to cipher text or plaintext before restoration.

chrisdl · 2018-06-27T21:37:39Z

These tests don't work in all pythons we support yet, so let's work on this! Thanks for the PR!

Used the b function from compat in order to fix the incompatabilities... also fixed the missing runner

… both our versions of python

… It will test if changes to the ciphertext will still appear in the ciphertext after decrypting then reencrypting. plaintext = "even write in it for the test" - encrypt -> ciphertext == """- - - Encrypted by jak - - - ......." - append to ciphertext "Something" -> - decrypt file -> plaintext = "even write in it for the test" - reencrypt -> ciphertext == """- - - Encrypted by jak - - - ....... Something"

carolinedil · 2018-07-02T16:10:17Z

See if it works now with the changes I've made. I've tested on my computer with both workon py27 and workon py36.

…This can be changed by getting rid of the "--cov-report term-missing " part of the line I changed.

test_read_jakfile_standard_format will check if read_jakfile works as intended under regular circumstances. It is possible to make it more extensively specific, however I didn't feel that was needed test_read_jakefile_malformed will check if read_jakfile will return an error when the jakfile doesn't fit the format it ought to. I didn't know how to do it other than having the actual jakfile altered and then to return it to the form it was before (then if that doesn't work set it to how it would be when creating a new jakfile.

This test gives coverage to the error that hadn't been tested of missing key error within _select_files_logic

…e coverage. This checks that when requesting a keyfile that doesn't exist, an error will be returned that that keyfile doesn't exist.

…I added a create jakfile at the beginning of decorators in the hopes it would fix the problem of no jakfile for all the other tests in that file too.

…d something so that we write to the file and then check that the regular jakfile stays the same and our test one changes.

… check if the mock file was properly accessed, but the jakfile wasn't altered

Also parametrization and crypto cleaned up a bit.

Also got rid of straying imports

Caroline DiLorenzo added 8 commits June 27, 2018 11:14

Added a test for create_or_overwrite_file

6bb2e3f

Added Crypto test for giving the wrong key and expecting the Wrong Ke…

334a371

…y error

Added Crypto Test that checks if error is properly conveyed when tryi…

9b3b5ad

…ng to decrypt a file that has "already been decrypted" (Simply have a file that is not in encrypted form).

Added Crypto Test that checks if error is properly conveyed when tryi…

559a877

…ng to encrypt a file that has already been encrypted.

Added Crypto test that checks if read_file works on fills with conten…

4f0fcd2

…t written to them.

Added Crypto test that checks if read_file throws an error when tryin…

9f60d4d

…g to use read_file on an empty file.

Added Crypto test that tests the functions of restore_from_backup whe…

0f02a7d

…n plaintext has been encrypted and the resultant cipher text is decrypted then plaintext is altered.

Added Crypto test that checks if _restore_from_backup works under con…

3fae654

…ditions with no alteration to cipher text or plaintext before restoration.

chrisdl self-assigned this Jun 27, 2018

chrisdl added the don't merge label Jun 27, 2018

Caroline DiLorenzo added 7 commits June 29, 2018 16:15

Sudoed the following lines which causes less errors on my system

76f212d

wrote preliminary for test__restore_from_backup_ciphertext_altered

f3bf268

Re-added the runner for crypto

b47787b

Crypto tests have been fully fixed.

96c9815

Used the b function from compat in order to fix the incompatabilities... also fixed the missing runner

Fixed test_create_or_overwrite_file_decoding so it is compatible with…

75c86e0

… both our versions of python

My changes to the vagrantfile made this the vagrant machine work now

5b5ee59

Caroline DiLorenzo and others added 11 commits July 2, 2018 12:27

The lines that are missing coverage are now output when running tox. …

7daf32b

…This can be changed by getting rid of the "--cov-report term-missing " part of the line I changed.

Added to Decorators test__select_files_logic.

c980c6f

This test gives coverage to the error that hadn't been tested of missing key error within _select_files_logic

Added extra test to test_select_key_logic that will allow greater lin…

5438772

…e coverage. This checks that when requesting a keyfile that doesn't exist, an error will be returned that that keyfile doesn't exist.

My computer had a jakfile so it worked, but travis did not have one. …

2a6f02c

…I added a create jakfile at the beginning of decorators in the hopes it would fix the problem of no jakfile for all the other tests in that file too.

improve helper tests a little. add parametrization to one.

e56d189

moved malformed read jakfile from test_decorators to test_helpers

3d022d7

moved test that checks exception is thrown for select_files_logic.

210129b

remove double import.

bda4124

Paramatrized the tests the tes__restore_from_backup.

6835bc5

Parametrized in test__read_file in Crypto.

0359547

Caroline DiLorenzo added 6 commits July 3, 2018 14:05

Finished the TODO listed under test_create_jakfile. I might try to ad…

bed64a4

…d something so that we write to the file and then check that the regular jakfile stays the same and our test one changes.

Added the promised part where we write something to the mock file and…

31e6498

… check if the mock file was properly accessed, but the jakfile wasn't altered

Made it so that test_create_jakfile works properly with Travis now.

985a671

Also parametrization and crypto cleaned up a bit.

abspath did not play well with Travis

7abaf2d

Added test_backup_file_content and removed it's TODO notice in helpers.

ce3a7cc

Also got rid of straying imports

Added second TODO test for get_backup_content

50a11e1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More tests #53

More tests #53

carolinedil commented Jun 27, 2018 •

edited by chrisdl

Loading

chrisdl commented Jun 27, 2018

carolinedil commented Jul 2, 2018

More tests #53

Are you sure you want to change the base?

More tests #53

Conversation

carolinedil commented Jun 27, 2018 • edited by chrisdl Loading

chrisdl commented Jun 27, 2018

carolinedil commented Jul 2, 2018

carolinedil commented Jun 27, 2018 •

edited by chrisdl

Loading