Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Visualizer #43

Closed
bbengfort opened this issue Sep 7, 2016 · 5 comments
Closed

Feature Visualizer #43

bbengfort opened this issue Sep 7, 2016 · 5 comments
Assignees
Labels
level: intermediate python coding expertise required priority: high should be done before next release type: feature a new visualizer or utility for yb
Milestone

Comments

@bbengfort
Copy link
Member

bbengfort commented Sep 7, 2016

This issue replaces #7

@bbengfort bbengfort added this to the Version 0.3 milestone Sep 7, 2016
@bbengfort bbengfort self-assigned this Sep 7, 2016
@bbengfort bbengfort added the ready label Sep 7, 2016
@rebeccabilbro rebeccabilbro added level: intermediate python coding expertise required priority: high should be done before next release type: feature a new visualizer or utility for yb labels Sep 7, 2016
@rebeccabilbro
Copy link
Member

Create a FeatureVisualizer base class where the intent is that it comes between or at the end of transformers but before the estimator. This should have

  • fit
  • transform
  • draw
  • fit_draw
  • fit_transform (alias for fit_draw)

Needs to extend BaseEstimator, BaseTransformer, and VisualizerMixin.

@bbengfort
Copy link
Member Author

@rebeccabilbro I've moved the FeatureVisualizer from yellowbrick.base to yellowbrick.features.base in order to keep the base class with the rest of the code.

As a result, I consider this story done!

@bbengfort bbengfort removed the ready label Oct 7, 2016
@rebeccabilbro
Copy link
Member

@bbengfort awesome! Should i be doing the same thing for ScoreVisualizer? e.g. moving regressors.py and classifiers.py into a separate folder with its own base?

@bbengfort
Copy link
Member Author

If you think that's better organized, then yes - but I wasnt quite sure how
to divide up the model space. We could save it for discussion after the 0.3
release!

On Friday, October 7, 2016, Rebecca Bilbro notifications@github.com wrote:

@bbengfort https://github.com/bbengfort awesome! Should i be doing the
same thing for ScoreVisualizer? e.g. moving regressors.py and
classifiers.py into a separate folder with its own base?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#43 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAth7sNKdFeCaaRhsRXnzTrGEndSfZouks5qxoX_gaJpZM4J2b6q
.

Sent from Gmail Mobile

@rebeccabilbro
Copy link
Member

Sounds good; opened new issue #65 for the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level: intermediate python coding expertise required priority: high should be done before next release type: feature a new visualizer or utility for yb
Projects
None yet
Development

No branches or pull requests

2 participants