Feature/async storage #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehni
force-pushed
the
master
branch
2 times, most recently
from
f3f4ac1
to
d0fbf55
Compare
lehni
reviewed
Apr 13, 2023
| get transaction() { return ctx.transaction }, | ||
| get logger() { return ctx.logger } | ||
| }, | ||
| () => next() |
There was a problem hiding this comment.
Can just be next, no need to wrap a function in a function ;)
lehni
reviewed
Apr 13, 2023
| Object.defineProperties(app, { | ||
| requestLocalStorage: { value: requestLocalStorage }, | ||
| locals: { get() { return requestLocalStorage.getStore() ?? {} } } | ||
| }) |
There was a problem hiding this comment.
Let's rename these:
requestStorage
requestLocalsAnd let's move the defineProperties() monkey-patching to the Application class properly:
constructor(...) {
this.requestStorage = new AsyncLocalStorage()
...
}
get requestLocals() {
return this.requestStorage.getStore() ?? {}
}
lehni
reviewed
Apr 13, 2023
| @@ -0,0 +1,17 @@ | |||
| import { AsyncLocalStorage } from 'async_hooks' | |||
|
|
|||
| export function setupRequestLocalStorage(app) { | |||
There was a problem hiding this comment.
Just setupRequestStorage() then
lehni
force-pushed
the
master
branch
2 times, most recently
from
19cd9f1
to
8c14378
Compare
ptoussai
force-pushed
the
feature/async-storage
branch
from
79468ed
to
d00f104
Compare
|
@ptoussai great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.