test: should resolve .ts from .js alias #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnusG
reviewed
Jul 20, 2022
| }, | ||
| existingFiles: [join("/root", "src", "foo.ts")], | ||
| requestedModule: "@/foo.js", | ||
| expectedPath: join("/root", "src", "foo.ts"), |
There was a problem hiding this comment.
Will your resolution work if the path is selected as follows?
Suggested change
| expectedPath: join("/root", "src", "foo.ts"), | |
| expectedPath: join("/root", "src", "foo"), |
If so #216 would address it as well - otherwise it does not.
|
Closed in favor of #216 |
jonaskello
pushed a commit
that referenced
this pull request
Jun 2, 2023
* Fix missing paths when using typescript's module nodenext feature This resolution requires relative/mapped import paths to end with .js Reference https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/#esm-nodejs * Add tests from #213 #213 * Add support for .mjs, .cjs and .jsx files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test confirms a bug reported in aleclarson/vite-tsconfig-paths#54
TypeScript allows importing a TypeScript module using a
.jsextension, and a.jsxextension for TSX modules.