Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue3189 fix get plugins for page #3190

Merged

Conversation

johnraz
Copy link
Contributor

@johnraz johnraz commented May 23, 2014

Fix for #3189

@yakky
Copy link
Member

yakky commented May 23, 2014

Spotted failures, but apparently not related to this PR
Usual travis snafuz?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.17%) when pulling d18a074 on johnraz:Issue3189-fix-get_plugins_for_page into 2d3e10a on divio:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.17%) when pulling d18a074 on johnraz:Issue3189-fix-get_plugins_for_page into 2d3e10a on divio:develop.

@johnraz
Copy link
Contributor Author

johnraz commented May 23, 2014

@yakky seems its selenium which is blowing python 3 up

@yakky
Copy link
Member

yakky commented May 23, 2014

For no apparent reason, given that yesterday everything is fine and this PR doesn't touch the frontend tests

@yakky
Copy link
Member

yakky commented May 23, 2014

Build restarted, let's see

@johnraz
Copy link
Contributor Author

johnraz commented May 23, 2014

meh ?

@yakky
Copy link
Member

yakky commented May 24, 2014

Please rebase against develop to clear travis issues

@johnraz
Copy link
Contributor Author

johnraz commented May 24, 2014

Done.

@johnraz
Copy link
Contributor Author

johnraz commented May 24, 2014

Haaa it looks much better now :)

@coveralls
Copy link

coveralls commented May 24, 2014

Coverage Status

Coverage decreased (-0.1%) to 88.019% when pulling 8407ed1 on johnraz:Issue3189-fix-get_plugins_for_page into ff4beff on divio:develop.

yakky added a commit that referenced this pull request May 24, 2014
@yakky yakky merged commit bd278ea into django-cms:develop May 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants