This repository has been archived by the owner on Jan 30, 2021. It is now read-only.
Use require-dir to pull in tasks automatically #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the process of doing this I found 2 errors:
|
|
Looks like requireDir supports recursive imports: |
|
Good catch - I just tried globs and assumed :) Fixed |
baer
force-pushed
the
feature/require-dir
branch
from
e9065a8
to
b0ec59f
Compare
| require("./tasks/frontend/build-js-dev")(gulp, webpackDevConfig); | ||
| require("./tasks/frontend/test-browser")(gulp, config, webpackDevConfig); | ||
| require("./tasks/frontend/test-karma")(gulp, config, karmaConfig); | ||
| requireDir("./tasks", {recurse: true}); |
|
Once everything passes |
baer
force-pushed
the
feature/require-dir
branch
from
b0ec59f
to
4278f0c
Compare
baer
added a commit
that referenced
this pull request
Nov 10, 2014
Use require-dir to pull in tasks automatically
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7
This PR aligns the project with the "blessed" way to require tasks as per the Gulp project. Two things had to happen for this to work:
require-dirto auto require any task placed under tasks.NOTE: This PR is best viewed without whitespace changes. Use the query param
?w=1to do that.