-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovoverlay import mechanics don't seem to allow file name attribute discrepancy and also do not distinguish between nixos and master #76
Comments
As for overlays on master: Couldn't we just drop overlays application on |
We definitely need to simplify the semantics here. Originally, the name discrepency was on purpose to allow for "utility" overlays, such as In general though, I want a simpler and more robust overlay interface. For example, is very brittle and easy to break or misuse. |
Indeed it is: 😉
|
In several places `mkFlake` assumes an valid value is set, here. fixes: #76
In several places `mkFlake` assumes an valid value is set, here. fixes: #76
Because of
https://github.com/nrdxp/nixflk/blob/d0fe508da20695bd72c1a5eebd3cb113778366ac/flake.nix#L51
in conjunction with
https://github.com/nrdxp/nixflk/blob/d0fe508da20695bd72c1a5eebd3cb113778366ac/lib/utils.nix#L89-L92
https://github.com/nrdxp/nixflk/blob/d0fe508da20695bd72c1a5eebd3cb113778366ac/overlays/kakoune.nix#L13
would not be made available in
pkgs
.In general, I'm not sure if "too much magic" here is really a win or if overlays could be managed in a more transparent manner.
I really like the way how flake-utils's simpleFlake commands name spacing (see #60).
That approach doesn't limit overlaying "stock" packages, though, through a little extra helper that would read overlays from a non name spaced portion of the overlay file:
On the other hand it seems that we need a way to target an overlay either at
master
or atnixos
, since on the contrary we expose the users to nasty and unexpected side effects of the implementation detail thatgenPackages
targets both branches.The text was updated successfully, but these errors were encountered: