Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken lib follows #348

Closed
wants to merge 1 commit into from
Closed

Conversation

LiGoldragon
Copy link

I was unable to override the nixlib passed to inputs which used haumea's input.

@whs-dot-hk
Copy link
Contributor

You can override in flake.nix with inputs.dmerge.inputs.nixlib.follows = "sth";

@blaggacao
Copy link
Collaborator

Ah just saw this. Yes, if I'd prefer if the direct second-level input override is workable, because this adds another (separate) input entry for std in downstream flake.lock files and std already suffers from excessive inputs, so if anything, I'd like to reduce them as much as we can (and keep them minimal).

@whs-dot-hk
Copy link
Contributor

O, sorry I actually mean inputs.std.inputs.dmerge.inputs.nixlib.follows = "sth";

@LiGoldragon
Copy link
Author

O, sorry I actually mean inputs.std.inputs.dmerge.inputs.nixlib.follows = "sth";

That doesn't work:

 error: input 'std/dmerge/nixlib' follows a non-existent input 'std/haumea/nixpkgs'

Even if std.inputs.haumea.inputs.nixpkgs.follows is set.

@LiGoldragon
Copy link
Author

Aditionally, the whole of avoiding to call lib by its long-established name is absurd. Nixpkgs is not lib.

@blaggacao
Copy link
Collaborator

blaggacao commented Sep 13, 2023

Nixpkgs is not lib.

I agree. There's semantic value to this PR, regardless if it could be worked around. Maybe that should prime over reduction of inputs.

divnix/hive#22

@blaggacao
Copy link
Collaborator

adapted in #349

@blaggacao blaggacao closed this Sep 13, 2023
@LiGoldragon
Copy link
Author

adapted in #349

You're awesome! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants