Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmented value redirect url's wont work if they are hyphenated #3

Open
amorwal opened this issue Aug 19, 2016 · 3 comments
Open

Segmented value redirect url's wont work if they are hyphenated #3

amorwal opened this issue Aug 19, 2016 · 3 comments

Comments

@amorwal
Copy link

amorwal commented Aug 19, 2016

Currently in the "Segmented value redirect" option when you have a mapping as shown below wont work.

'/url-prefix/:url-name/url-postfix': 'new/:url-name/:url-postfix',

Whereas, same scenario with '_' would work, like shown below
'/url_prefix/:url_name/url_postfix': 'new/:url_name/:url_postfix',

@scottcorgan
Copy link
Member

Good find. Working on a fix. Should be out in the next day!

@amorwal
Copy link
Author

amorwal commented Aug 19, 2016

Thanks Appreciate it! Sent another issue on package pathetic[] which has
dependency on npm pathematics which one of dependency on redirects. I
thought would be interesting for you to checkout.

scottcorgan/pathetic#1

Thanks

On Fri, Aug 19, 2016 at 12:08 PM, Scott Corgan notifications@github.com
wrote:

Good find. Working on a fix. Should be out in the next day!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASUyHwKo9uHjXzM-imJhVdRVlUpFHqoeks5qhf89gaJpZM4Jowqp
.

[image: Holonis, Inc.] http://www.holonis.com/

Arvind Morwal | Director of Engineering
dbaird@holonis.com | 888.552.4037 ext. 800

_Holonis, Inc._750 B St. Suite 1230
San Diego, CA 92101
www.holonis.com

[image: Facebook] https://www.facebook.com/holonis[image: Twitter]
https://twitter.com/holonis[image: Google Plus]
https://plus.google.com/+HolonisSanDiego[image: Youtube]
http://www.youtube.com/user/holonistv[image: Linkedin]
http://www.linkedin.com/company/holonis[image: Instagram]
http://instagram.com/holonisgram[image: pinterest]
http://pinterest.com/holonis/

This e-mail message may contain confidential or legally privileged
information and is intended only for the use of the intended recipient(s).
Any unauthorized disclosure, dissemination, distribution, copying or the
taking of any action in reliance on the information herein is prohibited.
E-mails are not secure and cannot be guaranteed to be error free as they
can be intercepted, amended, or contain viruses. Anyone who communicates
with us by e-mail is deemed to have accepted these risks. Company Name is
not responsible for errors or omissions in this message and denies any
responsibility for any damage arising from the use of e-mail. Any opinion
and other statement contained in this message and any attachment are solely
those of the author and do not necessarily represent those of the company.

@scottcorgan
Copy link
Member

@amorwal can you go ahead and submit a PR with a failing test to show this? It would be very helpful.

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants