DB migration for key rotator #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
force-pushed
the
inahga/key-rotator-migration
branch
from
4af144d
to
fef3ffe
Compare
divergentdave
approved these changes
Jun 5, 2024
branlwyd
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #2147.
It's generally risky to directly add a NOT NULL column with our usual migration workflow, because older versions of Janus missing application code won't know about the new column.
Work around this by using an intermediate
-infinitydefault for the column. This works becauseglobal_hpke_keysis not frequently used at the moment, so the window of time where someone can insert or modify rows on the old Janus version is low. Even if they do, the worst case is that the key rotator induces an early rotation of the key.This migration blocks readers while it's applied. However, readers run in a background task to refresh their cache of this table, so it's not a big deal if they're blocked for longer.