Feature flag for requiring global HPKE keys #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branlwyd
reviewed
Jul 1, 2024
| /// Experimental. Always advertise global HPKE keys instead of per-task HPKE keys. This will | ||
| /// become on by default in a future version of Janus. | ||
| #[serde(default)] | ||
| pub require_global_hpke_keys: Option<bool>, |
There was a problem hiding this comment.
nit: is None the same as Some(false)? if so, for simplicity I think this should just be a bool which defaults to false, so that we only interpret a missing value once.
inahga
force-pushed
the
inahga/require-global-keys
branch
from
3503372
to
aeaba92
Compare
inahga
force-pushed
the
inahga/require-global-keys
branch
from
aeaba92
to
1543ca7
Compare
|
Eh, pulling this back to draft, I think some work on integration/interop tests is justified here. |
|
I've made integration and inteorp tests use the flag. I'll make unit tests use it in the next PR, to keep this PR relatively small. |
tgeoghegan
approved these changes
Jul 8, 2024
branlwyd
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #2147.
Introduces a feature flag
require_global_hpke_keys. When this is enabled:GlobalHpkeKeypairCacheblocks and retries fetching keys until it gets a list containing at least one active key. This is a bootstrapping case--it allows for the key rotator to do initialization, whether it's running in-process or separately./hpke_configsendpoint unconditionally returns global keys, regardless of the?task_idparameter.Draft, as it needs refactoring and more testing. Looking for feedback on whether the overall approach is sane.