Remove rust-toolchain.toml
#198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My aim in introducing a `rust-toolchain.toml` was to ensure that all builds of crate `prio` would use a consistent Rust toolchain. However there's two problems with this. First, Rust projects that pull in crate `prio` ignore its `rust-toolchain.yaml`. Second, dependabot doesn't know about `rust-toolchain.yaml`, which means that our toolchain was falling behind the latest releases from the Rust project. We now instead specify a `rust-version` in `Cargo.toml`, which enforces a minimum toolchain version for using `prio`. I specified 1.58 because that's what GitHub Actions workers currently install. This commit also fixes some warnings uncovered by building the crate with a more recent toolchain (1.59 on my machine).
divergentdave
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My aim in introducing a
rust-toolchain.tomlwas to ensure that allbuilds of crate
priowould use a consistent Rust toolchain. Howeverthere's two problems with this. First, Rust projects that pull in crate
prioignore itsrust-toolchain.yaml. Second, dependabot doesn't knowabout
rust-toolchain.yaml, which means that our toolchain was fallingbehind the latest releases from the Rust project. We now instead specify
a
rust-versioninCargo.toml, which enforces a minimum toolchainversion for using
prio. I specified 1.58 because that's what GitHubActions workers currently install.
This commit also fixes some warnings uncovered by building the crate
with a more recent toolchain (1.59 on my machine).