vdaf: Replace the PrepareTransition::Fail variant
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branlwyd
approved these changes
May 20, 2022
tgeoghegan
approved these changes
May 23, 2022
cjpatton
force-pushed
the
cjpatton/vdaf-first-round
branch
2 times, most recently
from
19f2bb3
to
1f7265e
Compare
cjpatton
force-pushed
the
cjpatton/2-prep-trans-fail
branch
from
b78f073
to
59d63bc
Compare
Removes the `PrepareTransition::Fail` variant and has `prepare_step()` output a `Result<PrepareTransition, VdafError>`. Instead of returning `PrepareTransition::Fail(e)`, implementations of this method now simply return `Err(e)`.
cjpatton
force-pushed
the
cjpatton/2-prep-trans-fail
branch
from
59d63bc
to
ea0f28e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #218 (merge that first).
Closes #221.
Removes the
PrepareTransition::Failvariant and hasprepare_step()output a
Result<PrepareTransition, VdafError>. Instead of returningPrepareTransition::Fail(e), implementations of this method now simplyreturn
Err(e).