Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-constant-time comparisons of secret values. #734

Merged
merged 7 commits into from
Sep 8, 2023

Commits on Sep 7, 2023

  1. Remove non-constant-time comparisons of secret values.

    This affects the types representing:
      * Input shares
      * Preparation states
      * Output shares
      * Aggregate shares
    
    Mostly, the comparisons were either dropped entirely or updated to be
    test-only.  Input shares were instead given a constant-time equality
    implementation, as it is believed this is required for DAP
    implementations.
    
    PartialEq & Eq implementations are still derived when the "test-util"
    feature is enabled. This is to ease testing for users of this library.
    branlwyd committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    fe2e421 View commit details
    Browse the repository at this point in the history
  2. Code review.

    branlwyd committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    0b624de View commit details
    Browse the repository at this point in the history
  3. Tests.

    branlwyd committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    1d54c6d View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Code review.

    branlwyd committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    676609b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7618ecf View commit details
    Browse the repository at this point in the history
  3. Last, last review comment.

    Getting `option_ct_eq` to work in the last place it needed to required a
    few changes.
    branlwyd committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    00fef14 View commit details
    Browse the repository at this point in the history
  4. cargo fmt

    branlwyd committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    c1d5494 View commit details
    Browse the repository at this point in the history