Remove deprecated methods #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
approved these changes
Nov 22, 2023
src/topology/ping_pong.rs
Outdated
| /// does not, because [`crate::vdaf::Aggregator::prepare_preprocess`] does not take the | ||
| /// aggregation parameter. This may change in the future if/when [#670][issue] is addressed. | ||
| /// | ||
| /// | ||
| /// [VDAF]: https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-vdaf-07#section-5.8 | ||
| /// [issue]: https://github.com/divviup/libprio-rs/issues/670 |
There was a problem hiding this comment.
Suggested change
| /// [issue]: https://github.com/divviup/libprio-rs/issues/670 |
Looks like the issue link can go away.
src/topology/ping_pong.rs
Outdated
| /// does not, because [`crate::vdaf::Aggregator::prepare_preprocess`] does not take the | ||
| /// aggregation parameter. This may change in the future if/when [#670][issue] is addressed. | ||
| /// | ||
| /// | ||
| /// [VDAF]: https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-vdaf-07#section-5.8 | ||
| /// [issue]: https://github.com/divviup/libprio-rs/issues/670 |
There was a problem hiding this comment.
Suggested change
| /// [issue]: https://github.com/divviup/libprio-rs/issues/670 |
Same as above.
divergentdave
force-pushed
the
david/remove-deprecated
branch
from
51f6cad
to
8995376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes two deprecated methods, fixes doctests, and cleans up some related outdated comments. Closes #745.