Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prio3: Decouple the algorithm ID from the FLP circuit #855

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Prio3: Decouple the algorithm ID from the FLP circuit #855

merged 2 commits into from
Nov 29, 2023

Conversation

cjpatton
Copy link
Collaborator

@cjpatton cjpatton commented Nov 29, 2023 •
edited
Loading

Closes #854.

This requires an API-breaking change.

@cjpatton
Replace Vdaf::ID with Vdaf::algorithm_id(&self) -> u32
5ba8b3b 
Instead of defining the algorithm ID as an associated type, define a
method for returning it from an instance of the VDAF. This allows us to
provide more flexibility for variants of (standardized) VDAFs.
@cjpatton cjpatton requested a review from a team as a code owner November 29, 2023 18:14
divergentdave
divergentdave approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@divergentdave divergentdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like taking the algorithm_id as a parameter in Prio3::new(), at that point the circuit, XOF, and field are all determined.

@cjpatton
Prio3: Decouple the algorithm ID from the FLP circuit
a6689de 
Move `Type::ID` to `Prio3::new()`. This allows new Prio3 variants to be
befined for a standard circuit.
@cjpatton
Copy link
Collaborator Author

Force-pushed with clippy fix.

@cjpatton cjpatton merged commit 4ca547f into main Nov 29, 2023
6 checks passed
@cjpatton cjpatton deleted the cjpatton/854-new-method branch November 29, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divergentdave divergentdave divergentdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prio3: Codepoints for algorithm variants
2 participants
@cjpatton @divergentdave