Split FieldError::ModulusOverflow variant #856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FieldError::ModulusOverflow
variant is currently used in three situations:try_from_bytes()
: This is the original use of this error, and it directly matches the existing error message. It decodes an integer from a byte slice, compares the integer against the modulus, and returns a field element.valid_integer_try_from()
: This converts from one integer type to another, and additionally compares against the field modulus.Using
ModulusOverflow
in the bit vector case is a misnomer, as we're checking a different condition. Additionally, invalid_integer_try_from()
, no byte slice is involved. This PR introduces a dedicated error variant for the bit vector helper, and rewrites the existing message forModulusOverflow
, so that error messages better align with their causes.