Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap MIDI APIs #16

Closed
Boddlnagg opened this issue Mar 18, 2017 · 5 comments
Closed

Wrap MIDI APIs #16

Boddlnagg opened this issue Mar 18, 2017 · 5 comments

Comments

@Boddlnagg
Copy link
Contributor

If this crate also contained the MIDI APIs, I could use it in https://github.com/Boddlnagg/midir. Since you say that these APIs are not implemented "mostly because nobody asked for them", I'm just going to ask for them now 😉

I'm currently wrapping some parts myself (https://github.com/Boddlnagg/midir/blob/master/src/backend/alsa/wrappers.rs), mostly to be able to use RAII, but I'm not sure if those wrappers are actually safe. They are used in https://github.com/Boddlnagg/midir/blob/master/src/backend/alsa/mod.rs (ALSA is actually the most complicated of the backends in midir ...).

@diwic
Copy link
Owner

diwic commented Mar 19, 2017

Your request is hereby noted! :-)
I'll have a look at your wrap code - if I find it suitable, am I allowed to copy/paste freely from your code into this repository or would you prefer I rewrite it?

@Boddlnagg
Copy link
Contributor Author

You are allowed to copy/paste freely.

@diwic
Copy link
Owner

diwic commented Mar 26, 2017

@Boddlnagg
Okay, so I've been working on this quite a bit this week. The seq API is indeed huge. I started with the parts that you seemed to need and I think I'm almost done with that part now (although I probably have missed something, and it could use some more testing).

Would you mind having a look and see if it looks the way you expect?

(Btw, I didn't end up copy-pasting much. Mostly a few constants)

@Boddlnagg
Copy link
Contributor Author

@diwic Thanks a lot! Unfortunately I don't have much time this week (and probably also the coming weeks), so it will take some time until I can have a look ... sorry.

@diwic
Copy link
Owner

diwic commented Mar 29, 2017

@Boddlnagg
Cool. I've just released a new version of alsa-rs where all this is implemented (I hope), so I'm closing this issue now. Feel free to reopen (or open a new issue) in case if there's something I missed etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants