Allow for disconnect from server on shell close. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badcure
force-pushed
the
disconnect_from_server
branch
from
14a67ab
to
7e12f88
Compare
badcure
force-pushed
the
disconnect_from_server
branch
from
e61f787
to
001b2cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for completely disconnecting from the server if the shell has closed, closing all TCP connections. The existing behavior should be the same.
There was some unit tests added to mock requests in PR #131 . If you would like additional unit tests, I can either wait for that PR to be merged or move both code into one to re-use what is there.