-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PSRP Support #162
Add PSRP Support #162
Conversation
…to send to the server and receive
@nitzmahone here is the big beast, appreciate you have limited time but I am happy to work with you to get this release ready and ensure it doesn't negatively impact downstream projects. Let me know your thoughts on all this when you can. Edit: I'm not sure if you can do this but I was also wondering if you could add me as a maintainer of this repo so I am can go through issues and PRs once this is all done. |
@jborean93 Daaaang, you've been busy. :) I've blocked out a half day on April 3 (hopefully Ansible stuff will be down to a smolder by then) to just focus on your NTLM encryption PR and this PR. Looks great at first glance, but obviously with something this large, the devil's in the details... |
A lot of banging my head against the wall due to really crappy logging on Microsoft's part and just unexplained occurrences of Shell's disappearing but I got there in the end :). I left the encryption stuff out of this PR as I wasn't sure what will eventually change when you get time to have a look through it and didn't want to add any more complexity to this than what is already there. I'm also currently spiking out a new python library solely for transferring and receiving files so non-Ansible users can have that ability. So far it seems quick but haven't compared to the current Ansible timings and have come across a weird issue with files > 30MB due to |
After a lot of time, I finally created another library without the shackles of backwards compatibility with pywinrm here https://github.com/jborean93/pypsrp. Feel free to have a closer look at that if you are interested. |
This is a pretty big PR so I am all open to suggestions to make it as smooth as possible. This PR brings in the following options/changes
plaintext
andssl
auth options to make things simpler and less confusingThings I know I have broken and am open to how we deal with this