Removed debug print statement #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reidrac Sure, "logging" module from Python starndard library must be integrated into pywinrm. Unfortunately I did not have a time to work on this. I would be happy to accept any pool requests that add logging support if it follows common/best practices (for example, one of them is "use module-level or class-level loggers and do not use root logger"). |
|
OK, I'll think about it. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also I wonder if you would be open to use Python's "logging" facility instead of the occasional "print", so you could leave debug lines without affecting the code when is not run in debug mode.
Thanks for pywinrm, it is very useful!