Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setup.cfg to configure command for rpm build #49

Merged
merged 1 commit into from
Oct 9, 2015

Conversation

lukas-bednar
Copy link
Contributor

In order to build rpm for this library, it requires adding dependency to build proper rpm package.

Change-Id: I04956694c85a4ff7aa8586bfec83f8361e23f181
Signed-off-by: Lukas Bednar <lbednar@redhat.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.36% when pulling d7a20f7 on lukas-bednar:setup_bdist_rpm into 3da6bec on diyan:master.

diyan added a commit that referenced this pull request Oct 9, 2015
Adding setup.cfg to configure command for rpm build
@diyan diyan merged commit f7dec15 into diyan:master Oct 9, 2015
@diyan
Copy link
Owner

diyan commented Oct 9, 2015

@lukas-bednar PR merged. What about python-kerberos optional dependency? Can we somehow flag it as optional/recommended/whatever in rpm package?

@lukas-bednar
Copy link
Contributor Author

@diyan unfortunately rpm-spec file doesn't provide option to include optional-dependency.
you can require dependency and it will get installed, or do not require it and it will not get installed, nothing between.

on other hand it would be possible to create meta-rpm which just groups several packages together, so it could be pywinrm + python-kerberos.

anyway I think it is not rpm's approach, when you need to use something extra / enable some feature, you do it explicitly. for example httpd & mod_ssl . you want to use SSL/TLS module for you Apache, you have to install mod_ssl explicitly and configure it accordingly.

@diyan
Copy link
Owner

diyan commented Oct 9, 2015

@lukas-bednar Clear. Thank you for explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants