Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed client cert auth with SSLContext #76

Merged
merged 2 commits into from
Oct 10, 2015

Conversation

nitzmahone
Copy link
Collaborator

Had to make some tweaks to client cert auth to get it working again with the SSLContext stuff (hadn't tested that part of the previous PR).

ditch unneeded conditional that would result in AttributeError for pre 2.7.9 Python
diyan added a commit that referenced this pull request Oct 10, 2015
fixed client cert auth with SSLContext
@diyan diyan merged commit 3015445 into diyan:v0.1.x Oct 10, 2015
@diyan
Copy link
Owner

diyan commented Oct 10, 2015

@nitzmahone Thank you.

@diyan
Copy link
Owner

diyan commented Oct 14, 2015

@nitzmahone @cchurch @pdunnigan I'm planning to tag 0.1.0 release on Friday or weekends, please let me know if you have any showstoppers. It will be a maintenance release without any major changes, so we could jump onto requests branch after that.

@pdunnigan
Copy link
Contributor

No problem.

Alexey Diyan mailto:notifications@github.com
October 14, 2015 at 4:34 AM

@nitzmahone https://github.com/nitzmahone @cchurch
https://github.com/cchurch @pdunnigan https://github.com/pdunnigan
I'm planning to tag 0.1.0 release on Friday or weekends, please let me
know if you have any showstoppers. It will be a maintenance release
without any major changes, so we could jump onto requests branch after
that.


Reply to this email directly or view it on GitHub
#76 (comment).

Matt Davis mailto:notifications@github.com
October 9, 2015 at 7:24 PM

Had to make some tweaks to client cert auth to get it working again
with the SSLContext stuff (hadn't tested that part of the previous PR).


    You can view, comment on, or merge this pull request online at:

#76

    Commit Summary


Reply to this email directly or view it on GitHub
#76.

@nitzmahone
Copy link
Collaborator Author

Sounds good to me- I've smoke tested this branch against Ansible 1.9.2 and 2.0 devel using every valid combo of http/https and basic/cert/kerb and all seems well.

Thanks!

@nitzmahone
Copy link
Collaborator Author

Any update on release plans?

@diyan
Copy link
Owner

diyan commented Oct 26, 2015

@nitzmahone Sorry, did not have a time to do it on the weekend. Will try to make a release this week.

@nitzmahone
Copy link
Collaborator Author

Anything I can do to help the release process along? Happy to do whatever...

@diyan
Copy link
Owner

diyan commented Nov 1, 2015

@nitzmahone @pdunnigan @cchurch New release is published on PyPI, please check how it will work for you - https://pypi.python.org/pypi/pywinrm/0.1.1

@nitzmahone
Copy link
Collaborator Author

Quick smoke test looks like it works great- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants