Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar: Added analog sonar support #940

Closed
wants to merge 7 commits into from
Closed

Sonar: Added analog sonar support #940

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2014

Added sonar support using the AP_Rangfinder_analog class instead of the
Maxbotix class. This brings to same as arduplane and ardurover. This
class is much nicer because we can tweek sonar values through GCS
parameters. Downside is now sonar selection is not trivial, may need to
implement simple config on GCS side or add a wiki for default settings
of most common analog sonars.
-Added enabled(bool) setter function to AP_Rangefinder_analog in order
to dynamically enable and disable sonar with chan7 or chan 8 options
-Added check to sonar health if sonar_alt - baro_alt < 10 meters to
prevent fly aways if sonar failed, or is covered up. **Not tested, needs
testing
-Added sonar_alt and sonar voltage reports to mavlink GCS, now displays
in mission planner correctly.
-User should set max_distance in parameters to appx 60% of max for
reliability reasons, because built in 60% check had to be removed.
-Added voltage report to CLI Test Sonar
-added option in apm_config.h to enable sonar tilt correction if one so
chooses to use this feature.

*Tested on Pixhawk, sonar pin 15 maxbotix MB1240XL, scale factor 2.42
*I don't this will fit on APM anymore?

Added sonar support using the AP_Rangfinder_analog class instead of the
Maxbotix class.  This brings to same as arduplane and ardurover.  This
class is much nicer because we can tweek sonar values through GCS
parameters.  Downside is now sonar selection is not trivial, may need to
implement simple config on GCS side or add a wiki for default settings
of most common analog sonars.
-Added enabled(bool) setter function to AP_Rangefinder_analog in order
to dynamically enable and disable sonar with chan7 or chan 8 options
-Added check to sonar health if sonar_alt - baro_alt < 10 meters to
prevent fly aways if sonar failed, or is covered up. **Not tested, needs
testing
-Added sonar_alt and sonar voltage reports to mavlink GCS, now displays
in mission planner correctly.
-User should set max_distance in parameters to appx 60% of max for
reliability reasons, because built in 60% check had to be removed.
-Added voltage report to CLI Test Sonar
-added option in apm_config.h to enable sonar tilt correction if one so
chooses to use this feature.

*Tested on Pixhawk, sonar pin 15 maxbotix MB1240XL, scale factor 2.42
*I don't this will fit on APM anymore?
Added sonar support using the AP_Rangfinder_analog class instead of the
Maxbotix class.  This brings to same as arduplane and ardurover.  This
class is much nicer because we can tweek sonar values through GCS
parameters.  Downside is now sonar selection is not trivial, may need to
implement simple config on GCS side or add a wiki for default settings
of most common analog sonars.
-Added enabled(bool) setter function to AP_Rangefinder_analog in order
to dynamically enable and disable sonar with chan7 or chan 8 options
-Added check to sonar health if sonar_alt - baro_alt < 10 meters to
prevent fly aways if sonar failed, or is covered up. **Not tested, needs
testing
-Added sonar_alt and sonar voltage reports to mavlink GCS, now displays
in mission planner correctly.
-User should set max_distance in parameters to appx 60% of max for
reliability reasons, because built in 60% check had to be removed.
-Added voltage report to CLI Test Sonar
-added option in apm_config.h to enable sonar tilt correction if one so
chooses to use this feature.

*Tested on Pixhawk, sonar pin 15 maxbotix MB1240XL, scale factor 2.42
*I don't this will fit on APM anymore?
@ghost ghost closed this Apr 20, 2014
@rmackay9
Copy link
Contributor

Supergoldfish,
I didn't see your pull request but this is definitely something we want to do. I might grab what you've done here and pull it in anyway.

@ghost
Copy link
Author

ghost commented Apr 21, 2014

OK Randy. I closed it because I didn't like the way I did the sonar health check against baro alt. I was attempting to prevent fly-aways if the copter sonar alt to baro alt was greater than 10 meters, (In the case of blocked sonar), but that solution was problematic because I didn't account for un-even terrain since baro alt is based on Home..

I can re-submit minus that check if you like, or remove that check on integration.

@rmackay9
Copy link
Contributor

David,
Ok, I didn't see that check so I'll remove that on intetgration. I think the solution for the sonar health is going to be to encourage people to move to the I2C sonar instead. They're the same price and it's a more sophisticated interface.
Txs again.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants