Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hascolor parameter to domoticz lights to allow for just plain dim… #396

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

imcfarla2003
Copy link
Contributor

This refactors the code in lightRequest.py to look for a hascolor config option.

If the option is available then just use a simple "Set Level" command to domoticz otherwise continue as before.

@imcfarla2003
Copy link
Contributor Author

Also added a fix for issue #147

@mariusmotea
Copy link
Member

From where is the "hascolor" value, because it is not present in hue api?

@imcfarla2003
Copy link
Contributor Author

There is a hascolor key on line 304 of HueEmulator.py for deCONZ lights - As there is no other way to tell HueEmulator there is no color when talking to domoticz I reused this. Have you a better suggestion? There doesn't seem to be a way to tell HueEmulator much about a device in domoticz and specifying colour values for a white dimmable light does not work.

@stale
Copy link

stale bot commented Jun 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 2 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This issue is stale, and will be closed label Jun 2, 2020
@mariusmotea mariusmotea merged commit 90d3f42 into diyhue:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue is stale, and will be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants