-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG support for django-filer #1226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gulpfile.js # package.json
…support # Conflicts: # filer/private/sass/components/_drag-and-drop.scss # filer/static/filer/css/admin_filer.css # filer/static/filer/css/maps/admin_filer.css.map
it is not supported by reportlabs and end of life anyway
yakky
reviewed
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a feature many users are waiting for: Uploaded images can now also be in SVG.
The heavy lifting of cropping and scaling SVG images is done inside easy-thumbnails (you need version 2.8rc0 or later).
Changes:
retina.js
from project. High resolution images now are handled by the attribute in<img srcset="..." ... />
– as the HTML standard requires._width
and_height
in modelImage
changed toFloatFields
, this because SVG images specify their size as floats.file_icon
tofile_admin_tags
. It handles the rendering of all file types.exists()
toMultiStorageFieldFile
, which checks if a file exists on disk.reportlabs
requires Python>=3.6.I would propose version number 2.2 for the upcoming release containing these changes.