fix: Simplify versioning interaction for better disentanglement #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksweb
approved these changes
Jul 4, 2023
marksweb
force-pushed
the
fix/use-versioning-api-not-helpers
branch
from
00fba51
to
f77d3aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an unnecessary import of
djangocms_versioning.helpers.remove_published_where. By importing this helper function, alias implicitly makes a very precise assumption on how versioning works which it should not.This helper function is replaced by the
admin_managerof the content model.This disentanglement is necessary to allow for alternative versioning packages to work with alias.