chore: Update pre-commit checks #217
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ALIAS_MENU_CREATE_IDENTIFIER = 'alias-add' | ||
| ALIAS_LANGUAGE_BREAK = 'alias-language' | ||
| ALIAS_MENU_IDENTIFIER = "alias" | ||
| ALIAS_MENU_CREATE_IDENTIFIER = "alias-add" |
Check notice
Code scanning / CodeQL
Unused global variable Note
| long_description=open('README.rst').read(), | ||
| long_description_content_type='text/x-rst', | ||
| platforms=['OS Independent'], | ||
| long_description=open("README.rst").read(), |
Check warning
Code scanning / CodeQL
File is not always closed Warning
|
The test failures might be a clue as to a change. For the most part it's a case of |
|
@fsbraun If you've got some time, could you take a look and see if I'm missing something with the tests? |
| {{ instance.body|safe }} |
There was a problem hiding this comment.
@raffaellasuardini Here, a newline has been added which must be removed. Sometimes editors do this. I have had this issue with PyCharm, for example.
Maybe this already fixes the failing tests?
There was a problem hiding this comment.
It's the .editorconfig file which says insert_final_newline = true on all file types.
@raffaellasuardini I think it's worth updating this block in there;
[*.{scss,js,html}]
max_line_length = 120
indent_style = space
quote_type = double
Update that to:
[*.{scss,js,html}]
max_line_length = 120
indent_style = space
insert_final_newline = false
quote_type = double
There was a problem hiding this comment.
Ah, there we go. I'll also have to do this for djanogcms-text[-ckeditor]...
updated .pre-commit-config.yaml: inserted ruff and pre-commit hooks
created Ruff configuratio in pyproject.toml