Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Carousel does not start with CMS v4 #107

Merged
merged 16 commits into from
Feb 23, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Feb 23, 2023

When used with Django CMS 4+ the first carousel slide is not activated preventing the carousel from starting in the first place.

@fsbraun fsbraun merged commit 2700726 into django-cms:master Feb 23, 2023
@fsbraun fsbraun deleted the fix/carousel_cms_v4 branch April 19, 2023 16:38
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (224506c) to head (6b3d89c).
Report is 139 commits behind head on master.

Files Patch % Lines
djangocms_frontend/helpers.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   86.28%   85.93%   -0.35%     
==========================================
  Files         110      110              
  Lines        2975     2980       +5     
  Branches      322      323       +1     
==========================================
- Hits         2567     2561       -6     
- Misses        310      318       +8     
- Partials       98      101       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant