feat: Added support for django-cms 4.x #201
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support added for django-cms 4.x. It will eventually be replaced by djangocms-url-manager bu so many projects use djangocms-link it would be wrong to deprecate it now when a fix is so easy.
To install this PR to test the changes fix the issues found in the following project: https://github.com/django-cms/django-cms-quickstart
We'll need to add django-cms 4.x to the test suite for this package, I can do that next, for now you should have a working demo with django-cms link. We will in future need to work out a good way to remap old djangocms-link plugins to djangocms-url-manager plugins, this is not so easy because some use the djangocms-link field in their plugins, this is difficult to do with djangocms-url-manager currently. Something we can design int he DCA I am sure.
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.