-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
django 4.2 support added, python 3.10 support added. #87
django 4.2 support added, python 3.10 support added. #87
Conversation
Hi @fsbraun , this is the new PR against master branch, please review this one instead. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 77.82% 77.76% -0.06%
==========================================
Files 30 30
Lines 780 778 -2
Branches 76 76
==========================================
- Hits 607 605 -2
Misses 153 153
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one suggestion to keep the semantics for version checks consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the self.assertQuerySetEqual
change only comes with 4.2., so I've adjusted the logic: To the patch when django 4.1 or lower.
Add support for Django 4.2, now supports Django [3.2, 4.2]
Add support for Python 3.10, now supports Python [3.8, 3.9, 3.10]
Drop support for Django 2.x
Drop support for Python 3.6 & 3.7