Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django 4.2 support added, python 3.10 support added. #87

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

FreemanPancake
Copy link
Contributor

@FreemanPancake FreemanPancake commented Mar 14, 2024

  • Add support for Django 4.2, now supports Django [3.2, 4.2]

  • Add support for Python 3.10, now supports Python [3.8, 3.9, 3.10]

  • Drop support for Django 2.x

  • Drop support for Python 3.6 & 3.7

@FreemanPancake
Copy link
Contributor Author

Hi @fsbraun , this is the new PR against master branch, please review this one instead.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.76%. Comparing base (05ade78) to head (58af5c6).

❗ Current head 58af5c6 differs from pull request most recent head 33620d5. Consider uploading reports for the commit 33620d5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   77.82%   77.76%   -0.06%     
==========================================
  Files          30       30              
  Lines         780      778       -2     
  Branches       76       76              
==========================================
- Hits          607      605       -2     
  Misses        153      153              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one suggestion to keep the semantics for version checks consistent.

djangocms_url_manager/compat.py Outdated Show resolved Hide resolved
tests/test_settings.py Outdated Show resolved Hide resolved
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the self.assertQuerySetEqual change only comes with 4.2., so I've adjusted the logic: To the patch when django 4.1 or lower.

djangocms_url_manager/compat.py Outdated Show resolved Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
@fsbraun fsbraun merged commit 075d745 into django-cms:master Mar 14, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants