Make DEV_APPSERVER_OPTIONS options set for the 'default' database effective when using dbindexer. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing values in nested dicts (makes DEV_APPSERVER_OPTIONS work when defined for 'default').
|
Cannot fix the commits selection, here's a feature branch with the commit: https://github.com/django-nonrel/django-dbindexer/tree/feature/devserver-options-with-default-db . |
|
Applied patch; thanks. |
|
Hm, I've had a complaint from a djangoappengine user that this breaks on Python 2.5. |
|
GitHub won't let me reopen this. I'll open a new ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may set the options for the 'native' database, but the appengine base settings gives an example with 'default', so one ends up wondering why is this file stub exception still being thrown while I'm using SQLite.
This only updates the settings once, when the wrapper is created, however Django sometimes changes the settings (dict), so one cannot implement a virtual view on both option sets that would dynamically merge them (if that would be useful in any case).