Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return saved Notification instances from notify_handler, add tests #166

Merged
merged 1 commit into from
Apr 18, 2017
Merged

return saved Notification instances from notify_handler, add tests #166

merged 1 commit into from
Apr 18, 2017

Conversation

satyanash
Copy link
Contributor

implement the suggested fix and closes #165
add tests and fix existing ones

@coveralls
Copy link

coveralls commented Apr 18, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 89.202% when pulling 09d0181 on satyanash:master into d07c7a7 on django-notifications:master.

@zhang-z zhang-z merged commit 3423404 into django-notifications:master Apr 18, 2017
@zhang-z
Copy link
Contributor

zhang-z commented Apr 18, 2017

Thank you @satyanash !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

notify_handler(...) should return a list of created Notification instances instead of None
3 participants
@satyanash @coveralls @zhang-z