Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird results in attributes with patching Childs #297

Closed
viggo-devries opened this issue Oct 5, 2022 · 3 comments
Closed

Weird results in attributes with patching Childs #297

viggo-devries opened this issue Oct 5, 2022 · 3 comments
Labels
bug

Comments

@viggo-devries
Copy link
Contributor

Parent product has only attribute A filled
Child product has only attribute B filled

When patching the child product (does not matter what you change) The attribute value from A will also be saved on the child product.

parent:
image

child before patching:
image

child after patching and only changing the title:
image
@maerteijn
Copy link
Member

maerteijn commented Oct 6, 2022 •
edited
Loading

@viggo-devries Any chance you could add a test which “proves” the wrong behaviour?

@maerteijn maerteijn added the bug label Oct 6, 2022
@specialunderwear
Copy link
Member

This was proven in #299

@specialunderwear
Copy link
Member

The issue was fixed in oscar, as shown by these tests passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@specialunderwear @maerteijn @viggo-devries