Store SES sending statistics in model #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.py get_ses_statistics".
|
|
||
| Additionally, you can install ``pytz`` to localize the Amazon timestamp | ||
| (assumed UTC) to your locale. This will also make the date more readable, | ||
| using Django's default formatting. | ||
|
|
||
| Django Management Command | ||
| ========================= | ||
| If you need to keep sending statistics around for longer than two weeks, |
There was a problem hiding this comment.
Haha I'd change this to "keep send statistics", it's easy to misread as "keep sending" (happened to me :D)
|
@pcraciunoiu done :) |
| @@ -1 +1,3 @@ | |||
| from backend import SESBackendTest | |||
| from test_commands import SESCommandTest | |||
There was a problem hiding this comment.
With these here, the tests actually run twice for me. I think I prefer requiring nose and using the default test loader to having these imports here. I'll add docs.
There was a problem hiding this comment.
Isn't it better to just remove the "test_" prefixes so we don't have
to require nose? The imports is only a few lines and for me, the less
outside dependencies the better.
There was a problem hiding this comment.
Ok, let's do that then. Would you rename test_stats too?
…run twice by nose. Minor tweaks to command test.
|
Done! Let me know if there's anything else. |
pcraciunoiu
pushed a commit
that referenced
this pull request
Jan 5, 2012
Store SES sending statistics in model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is an updated version of #26 which I rebased to your master branch.