respect channel layer capacity in RedisChannelLayer.receive_buffer #219
Conversation
ryanpetrello
force-pushed
the
receive_buffer_capacity
branch
from
55e203f
to
a623e78
Compare
|
Hey @ryanpetrello — super stuff. I'm on 🏝 — give me a week or so to respond properly. Thanks! |
|
Hey @carltongibson, I'm jealous 😄 enjoy! |
|
Hey @carltongibson, Any chance you've had some time to look over this PR? I have a number of Ansible AWX users that are using a version of this patch, and it looks promising (none have yet reported back the memory leak after applying this patch; I've got at least one user who was seeing memory spikes every 48 hours and was restarting Daphne, and has now not reported any issues for nearly 3 weeks). |
|
Hi @ryanpetrello. I'm just back from holiday today (and had three versions of Django out this morning). I'll try and give it a look this week. Thanks for the hustle! 😀 |
|
Awesome - thanks! |
There was a problem hiding this comment.
Hi @ryanpetrello — I know this is a slow leak but do you think you can add some basic regression tests of the the new queue?
|
Hey @carltongibson - what sort tests are you looking for? Something that verifies that the queue won't grow beyond the configured capacity? |
|
Yeah, that sounds fine. "Did the basic behaviour break?" is enough. |
ryanpetrello
force-pushed
the
receive_buffer_capacity
branch
from
a623e78
to
d3c663b
Compare
|
@carltongibson test added - let me know if this is what you're looking for. |
ryanpetrello
force-pushed
the
receive_buffer_capacity
branch
2 times, most recently
from
0037e2a
to
b6afb2a
Compare
|
@ryanpetrello Quick glance, looks about right. Thank you. I'll have one more look over the issues and then we'll bundle this up for a release. 👍 Thanks for your input here! 🥇 |
ryanpetrello
force-pushed
the
receive_buffer_capacity
branch
from
b6afb2a
to
6361946
Compare
| @@ -544,7 +560,11 @@ async def new_channel(self, prefix="specific"): | |||
| Returns a new channel name that can be used by something in our | |||
| process as a specific channel. | |||
| """ | |||
| return "%s.%s!%s" % (prefix, self.client_prefix, uuid.uuid4().hex,) | |||
| return "%s.%s!%s" % ( | |||
There was a problem hiding this comment.
@carltongibson I changed this because black was complaining about it style-wise
There was a problem hiding this comment.
No problem. Whatever black says. 😀
carltongibson
force-pushed
the
receive_buffer_capacity
branch
from
6361946
to
e50bb5a
Compare
respect the capacity setting so that the receive_buffer does not grow without bounds see: django#212
carltongibson
force-pushed
the
receive_buffer_capacity
branch
from
e50bb5a
to
64b258f
Compare
cc @carltongibson
respect the capacity setting so that the receive_buffer does not grow
without bounds (which can lead to a memory leak)
see: #212
based on the idea outlined here:
#384