Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JavaScript tests DEP #14

Merged
merged 14 commits into from
Apr 28, 2015
Merged

Update JavaScript tests DEP #14

merged 14 commits into from
Apr 28, 2015

Conversation

treyhunner
Copy link
Member

Changes:

  • Recommend Blanket.js for code coverage instead of Istanbul
  • Note that Mocha can be used in a QUnit-like style but QUnit also supports auto-reset DOM fixtures
  • Note use of Gruntfile instead of gulpfile
  • Link to reference implementation
  • Note need for EditorConfig due to mixed indentation in JavaScript files

@jacobian
Copy link
Member

@treyhunner is this a WIP or ready to be merged?

carljm
carljm reviewed Apr 28, 2015
View reviewed changes
draft/0003-javascript-tests.rst
code directly from a web browser and therefore does not require generating new
test files.

Blanket.js should be used so that code coverage can be may be verified in a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"can be may be" - pick one :-)

@treyhunner
Copy link
Member Author

@carljm I incorporated changes which should address your feedback. @jacobian this is ready to be reviewed and merged.

carljm added a commit that referenced this pull request Apr 28, 2015
@carljm
Merge pull request #14 from treyhunner/update-js-tests-dep
6d1e446 
Update JavaScript tests DEP
@carljm carljm merged commit 6d1e446 into django:master Apr 28, 2015
@treyhunner treyhunner deleted the update-js-tests-dep branch April 29, 2015 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treyhunner @jacobian @carljm