-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop 'Last Modified' field #64
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the :Last-Modified:
to reflect when the content/substance of the DEP has last changed, instead of the last time anything in the file was changed? If the latter, then we should definitely remove them.
Even if it's the former, I believe it's out of sync for most of them. |
@felixxm thoughts? |
Speaking from my experiences on #86, I often forget to update the Big +1 👍 from me on this! |
+1. |
Isn't this whole PR a reason to keep the field? If this goes through then all the files histories get an extra commit to change the structure of the files thus polluting the git history with irrelevant history for the specific DEP. Before you know it you end up going through a long history just to find the last actual change relevant to the subject matter in the DEP. I think you should keep the meta-data in the file or adopt a standard to differentiate between content commits and structure commits, so it's easier to see the difference. But that's just my 2 cents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please! I don’t see how this field helps in any way considering if you really need that kind of date you’re better off looking at commits or pull request comments.
Note this PR would be even better if it also removed the field from the template file.
Following discussion in #62, realized this field is out of sync, we can retrieve the information from Git, and several DEP's never had the field.