Skip to content

Commit

Permalink
Fix #1409 -- Add Keyboard Accessibility To Hamburger Menu (#1418)
Browse files Browse the repository at this point in the history
* Change div to button

* Change border to 0
  • Loading branch information
ontowhee authored Nov 16, 2023
1 parent 80eae28 commit c14949c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion djangoproject/scss/_style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ blockquote {
.menu-button {
@include font-size(20);
background: $green-dark;
border-radius: 23px;
border: 0;
color: var(--menu);
cursor: pointer;
display: block;
Expand Down
2 changes: 1 addition & 1 deletion djangoproject/static/js/mod/mobile-menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ define([
init: function(){
var self = this;
self.menu.addClass('nav-menu-on');
self.button = $('<div class="menu-button"><i class="icon icon-reorder"></i><span>Menu</span></div>');
self.button = $('<button class="menu-button"><i class="icon icon-reorder"></i><span>Menu</span></button>');
self.button.insertBefore(self.menuBtn);
self.button.on( 'click', function(){
self.menu.toggleClass('active');
Expand Down

0 comments on commit c14949c

Please sign in to comment.