Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 1411 : h1_changed_to_h2 #1419

Closed
wants to merge 1 commit into from
Closed

Fixed 1411 : h1_changed_to_h2 #1419

wants to merge 1 commit into from

Conversation

specialorange
Copy link

…ingle h1 per page

@specialorange specialorange mentioned this pull request Oct 20, 2023
Open
@sabderemane
Copy link
Member

Hi @specialorange, can you please also post a screenshot of the site after your changes?

@sabderemane sabderemane linked an issue Nov 2, 2023 that may be closed by this pull request
MAJOR - Heading level 1 should be used for the title of the page #1411
Open
@thibaudcolas
Copy link
Member

👋 we want this change but this needs quite a bit more work. If we do this for the homepage only, we might as well do this for all <h1> on the page to not introduce inconsistencies between the sections. Possibly change the styles so we only change the semantics and not the aesthetics.

As-is this creates an inconsistency which is more problematic than the heading level semantics so I’ll close now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility styles
Projects
django accessibility improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAJOR - Heading level 1 should be used for the title of the page
3 participants
@specialorange @sabderemane @thibaudcolas