Swap unipath with pathlib

[relekang]

This is related to issue #343. Unipath has broken python 3 support.

[jezdez]

I'm pretty sure there are more of those hidden in the docs views

[relekang]

Thanks, I'll fix the rest later today

[relekang]

I updated it now. The docs site and ./manage.py update_docs works locally.

[jezdez]

I think using Path(__file__).resolve().parent would be nicer

[relekang]

I think it needs to be Path(__file__).resolve().parent.parent, since Path.parent is the same as Path.parents[0]. Do you still think it is nicer?

[jezdez]

Ah, yeah. That's still nicer I think, since it's clearer.

[jezdez]

This is awesome work @relekang, thank you! I've commented a bit above with general directions we should take here parent instead of parents[0] and using joinpath() instead of the operator overloading (via /). It's simply easier to maintain that way and brings less surprises to contributors.

[jezdez]

One thing that made me always wonder about pathlib is what makes Unipath not require the str() calls around settings for example that pathlib doesn't have?

[relekang]

One thing that made me always wonder about pathlib is what makes Unipath not require the str() calls around settings for example that pathlib doesn't have?

It's probably because AbstractPath in unipath inherits from str.

[relekang]

I have removed the operator usage and updated it to use parent instead of parents

[timgraham]

Is this branch meant to be compatible with both Python 2 and 3?

[relekang]

Yes, that was the thought :)

[timgraham]

I'm a bit confused on the added str stuff cause that's "bytes" on Python 2 and "unicode" on Python 3, right?

[relekang]

You are right, I did write it for python 3 and tested if it works on python 2 as well and did not think it through. It works since all the places it is used takes unicode or bytes on python 2. I can close this and make it a part of a python 3 pull-request or should I use django.utils.encoding.smart_text instead?

[timgraham]

Let's make a Python 3 pull request. I have time to do some manual testing tomorrow as well as update the server deployment, so let's see if we can get this finished off in the next couple days.