Improve drag & drop #26 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when drag element to element sice commit d4c3452, me must wait for 500ms for dnd. With this in place we can direct drag and move to another element without delay
when hold drag, it's shows the element component
when interval dnd element cleared, intervalCount set to be default value (0)
since commit b62ee57, user cannot direct hold and move element without waiting the delay
When duplicate element, select new duplicated element
Fixed selected and hovered element's offsets, and remove dedupe function.
Explaining when component or elements dropped
Since we have f77d73a, this flag not usefull anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains #26
Anything else you need to add?