Skip to content

Commit

Permalink
relax the version specification
Browse files Browse the repository at this point in the history
  • Loading branch information
hajifkd committed Jan 5, 2018
1 parent 44713ce commit dbea895
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion askama/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ with-rocket = ["rocket", "askama_derive/rocket"]
[dependencies]
askama_derive = { path = "../askama_derive", version = "0.5.0" }
askama_shared = { version = "0.5.0", path = "../askama_shared" }
iron = { version = "0.5", optional = true }
iron = { version = ">= 0.5", optional = true }

This comment has been minimized.

Copy link
@Eijebong

Eijebong Jan 6, 2018

Contributor

This is a bad idea :)
Not having an upper bound for a dependency means that iron could release a huge breaking change that could break askama for every user

This comment has been minimized.

Copy link
@hajifkd

hajifkd Jan 6, 2018

Author Contributor

Well, I agree with you. As I have mentioned at #63 , is >= 0.5, < 0.7 okay?

This comment has been minimized.

Copy link
@djc

djc Jan 6, 2018

Owner

Alright, I've added that limit in b8c261c.

This comment has been minimized.

Copy link
@Eijebong

Eijebong Jan 6, 2018

Contributor

Thanks 👍

rocket = { version = "0.3", optional = true }

[package.metadata.docs.rs]
Expand Down
2 changes: 1 addition & 1 deletion testing/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ nightly = ["rocket", "rocket_codegen", "askama/with-rocket"]

[dependencies]
askama = { path = "../askama", version = "*", features = ["with-iron", "serde-json"] }
iron = "0.5"
iron = "0.6"
rocket = { version = "0.3", optional = true }
rocket_codegen = { version = "0.3", optional = true }
serde_json = "1.0"
Expand Down

0 comments on commit dbea895

Please sign in to comment.