Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split askama_derive internals out into normal lib crate #835

Closed
wrapperup opened this issue Jul 1, 2023 · 2 comments
Closed

Split askama_derive internals out into normal lib crate #835

wrapperup opened this issue Jul 1, 2023 · 2 comments

Comments

@wrapperup
Copy link
Contributor

wrapperup commented Jul 1, 2023 •
edited
Loading

Following #828 and #826.

It would be nice to have the bulk of askama_derive moved into a normal lib crate. (ie. askama_derive_impl that uses proc_macro2::TokenStream). This would make it easier to profile and benchmark the derive macros, since it would let us use the implementation inside of a binary. Could also let you track performance regressions as part of the CI.
@djc
Copy link
Owner

djc commented Jul 1, 2023

We used to have this, but @Kijewski didn't like it. 😜 If we flip flop on this we should make sure not to introduce the same problems as before (I believe the previous merge mainly addressed issues with the integration switches).

See also #835, which I think has a bit stronger motivation?

@wrapperup
Copy link
Contributor Author

Resolved with #834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djc @wrapperup