Fix block partial rendering #1054
Conversation
| @@ -987,6 +989,9 @@ impl<'a> Generator<'a> { | |||
| if block_fragment_write { | |||
| self.buf_writable.discard = true; | |||
| } | |||
| if buf.discard != prev_buf_discard { | |||
There was a problem hiding this comment.
This seems surprising to me -- why do we only want to write if buf.discard is not equal to prev_buf_discard vs writing it out if buf.discard is just false?
There was a problem hiding this comment.
Interesting question. In my previous PR about this, if I wrote too early, we had content from sub-block that was rendered before its parent's, which was problematic. So in this case, if buf.discard != prev_buf_discard, then it's like that the parent is actually not something being displayed and so we should flush everything before the discard is true again.
Does my reasoning sound good to you and do you see potential corner-cases?
There was a problem hiding this comment.
Just thought: do you want me to add a code comment to explain this?
There was a problem hiding this comment.
Yes, that would be a good improvement.
There was a problem hiding this comment.
This comment is too long IMO and still doesn't make it very clear what case this is trying to fix/prevent. I want a comment here in like 4-5 lines that explains conceptually what case it is trying to handle.
There was a problem hiding this comment.
Updated the comment.
GuillaumeGomez
force-pushed
the
fix-block-partial-rendering
branch
from
252afe7
to
e44b0ca
Compare
Fixes #1052.
It didn't take into account that there would be other elements at the top level. Now it does.