Add redis pubsub pool and examples #71
Conversation
| @@ -15,3 +15,4 @@ redis = "0.16" | |||
|
|
|||
| [dev-dependencies] | |||
| tokio = { version = "0.2", features = ["macros"] } | |||
| futures-util = "0.3" | |||
There was a problem hiding this comment.
this is just need for the new redis examples, let me know if there is a better way of doing this ?
|
|
||
| #[async_trait] | ||
| impl bb8::ManageConnection for RedisPubSubConnectionManager { | ||
| type Connection = PubSub; |
There was a problem hiding this comment.
need to do 2 things, change connection type to PubSub
| self.client | ||
| .get_async_connection() | ||
| .await | ||
| .map(|conn| conn.into_pubsub()) |
There was a problem hiding this comment.
turn async connection into a pusbub connection into_pusbsub()
| async fn is_valid(&self, conn: &mut Self::Connection) -> Result<(), Self::Error> { | ||
| let test_sub_name = "__test__-sub-from-bb8"; | ||
| conn.subscribe(test_sub_name).await?; | ||
| conn.unsubscribe(test_sub_name).await |
There was a problem hiding this comment.
this feels hackish, but there is not much that can be done on a pubsub connection, basic CMD aren't available for example
|
I'm not really comfortable with supporting a pubsub pool as part of bb8-redis. It seems like a relatively niche use case and it's not at all clear that (most usages of) pubsub connections are a good match for pooling because the length of the "loan" from the pool could be relatively high. I think |
|
not a problem and thanks for the suggestion |
The Redis crate recently added redis pubsub subscription and would like to use this feature with bb8.
https://github.com/mitsuhiko/redis-rs/blob/master/examples/async-pub-sub.rs
PS: I am still super new to rust so probably can be cleaned up