-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomizeConnection::on_release() #94
Conversation
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 80.38% 81.80% +1.41%
==========================================
Files 6 6
Lines 668 720 +52
==========================================
+ Hits 537 589 +52
Misses 131 131
Continue to review full report at Codecov.
|
Looks good to me, thanks for following up on this! |
Co-authored-by: Antoine Gersant <antoine.gersant@lesforges.org>
I ended up removing it before release, since I'm not confident in the mechanics (I found at least one gap which wasn't that easy/clean to solve), and I can't really think of a use case. Will leave this out for now and add it back if someone comes up with a use case. |
This is exactly what we need for |
Can you open a new issue and preferably a PR? |
@agersant how do you feel about this?