Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dependency changes from e2288cbbfc9eb821679bc3ae836d3912de8aef0f #17

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Revert dependency changes from e2288cbbfc9eb821679bc3ae836d3912de8aef0f #17

merged 1 commit into from
Nov 17, 2020

Conversation

djc
Copy link
Owner

@djc djc commented Nov 17, 2020

Hey, thanks for merging #14! I noticed that, as part of #16 you introduced a number of changes to the dependencies, some of which make it harder for me to use your project. I was also a little surprised that some of your changes seem to have widened the version ranges allowed (hyper "0.13.5" -> "0.13", async-trait "0.1.31" -> "0.1") whereas others narrowed it (url "2" -> "2.2"). In particular, these changes make life harder for my project:

  • tokio 0.2 -> 0.3: this is a legitimate upgrade, but unfortunately the ecosystem has not moved along yet. In particular, hyper 0.13 actually relies on 0.2, so as written this change probably won't work exactly as you expect (maybe spawn two runtimes). My application is still relying on tokio 0.2 since it also uses hyper (and reqwest, which will update after hyper).
  • url 2 -> 2.2: this change doesn't make much sense to me since 2.2 is semver-compatible with 2, and gcp_auth doesn't (as far as I can tell) actually rely on any of the changes in version 2.2. Additionally, for various reasons my project currently relies on a fork of url 2.1.1, so life would be a little easier to just keep this at 2 (but would still allow other downstream crates to use 2.2 with gcp_auth).

@djc
Copy link
Owner Author

djc commented Nov 17, 2020

(Also, if you'd like I'd be happy to help with maintenance of this crate by doing code reviews.)

@hrvolapeter
Copy link
Collaborator

Sorry for the trouble, your reasoning seems solid. I've invited you as a collaborator to the repository

@hrvolapeter hrvolapeter merged commit 5cd5fed into djc:master Nov 17, 2020
@djc
Copy link
Owner Author

djc commented Nov 17, 2020

(I don't care that much, but since you seem to be sticking to semver quite closely, the reversion to tokio 0.2 probably merits another semver-breaking version number.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants